Skip to content

ci: use docs flavor for document generation#1336

Merged
Ron (rjaegers) merged 10 commits into
mainfrom
feature/use-docs-flavor
Jul 21, 2026
Merged

ci: use docs flavor for document generation#1336
Ron (rjaegers) merged 10 commits into
mainfrom
feature/use-docs-flavor

Conversation

@rjaegers

@rjaegers Ron (rjaegers) commented Jul 4, 2026

Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates the document generation workflow to use a dedicated container image for its environment, removing the need for manual dependency installation steps. The most important changes are:

Workflow environment update:

  • The generate-documents job in .github/workflows/wc-document-generation.yml now runs inside the ghcr.io/philips-software/amp-devcontainer-docs:v8.0.0 container, ensuring a consistent and pre-configured environment for document generation.

Simplification of setup steps:

  • Removed the manual installation of dependencies (plantuml and sbdl) from the workflow, as these are now expected to be provided by the container image.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings July 4, 2026 15:19
@rjaegers
Ron (rjaegers) requested a review from a team as a code owner July 4, 2026 15:19
Comment thread .devcontainer/docs/Dockerfile Fixed
Comment thread .github/workflows/wc-document-generation.yml Fixed
@rjaegers Ron (rjaegers) changed the title Feature/use docs flavor feat: use docs flavor for document generation Jul 4, 2026
@rjaegers Ron (rjaegers) changed the title feat: use docs flavor for document generation ci: use docs flavor for document generation Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1336

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 75.35 MB 75.35 MB +309 B (+0%) 🔼
linux/arm64 73.43 MB 73.43 MB +311 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.26s
✅ DOCKERFILE hadolint 4 0 0 0.31s
✅ JSON npm-package-json-lint yes no no 0.57s
✅ JSON prettier 43 6 0 0 0.87s
✅ JSON v8r 43 0 0 17.19s
✅ MARKDOWN markdownlint 13 0 0 0 1.26s
✅ MARKDOWN markdown-table-formatter 13 0 0 0 0.28s
✅ REPOSITORY betterleaks yes no no 1.28s
✅ REPOSITORY checkov yes no no 30.55s
✅ REPOSITORY gitleaks yes no no 1.32s
✅ REPOSITORY git_diff yes no no 0.02s
✅ REPOSITORY grype yes no no 70.56s
⚠️ REPOSITORY osv-scanner yes 1 no 0.76s
✅ REPOSITORY secretlint yes no no 2.21s
✅ REPOSITORY syft yes no no 2.73s
✅ REPOSITORY trivy yes no no 15.55s
✅ REPOSITORY trivy-sbom yes no no 0.41s
✅ REPOSITORY trufflehog yes no no 6.66s
⚠️ SPELL lychee 111 4 0 11.68s
✅ YAML prettier 32 0 0 0 1.42s
✅ YAML v8r 32 0 0 15.07s
✅ YAML yamllint 32 0 0 1.44s

Detailed Issues

⚠️ SPELL / lychee - 4 errors
📝 Summary
---------------------
🔍 Total..........154
🔗 Unique.........126
✅ Successful.....145
⏳ Timeouts.........0
🔀 Redirected......19
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........4
⛔ Unsupported......4

Errors in .github/CONTRIBUTING.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ (at 89:64) | Error (cached)

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (at 38:7) | Rejected status code: 403 Forbidden

Errors in .github/workflows/pr-conventional-title.yml
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ (at 42:95) | Network error: Connection reset by peer (os error 104)

Errors in README.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ (at 212:88) | Error (cached)

Hint: Followed 19 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned .devcontainer/cpp/requirements.txt file and found 20 packages
Scanned .devcontainer/docs/requirements.txt file and found 14 packages
Scanned test/embedded-rust/workspace/cortex-m/Cargo.lock file and found 20 packages
Scanned test/embedded-rust/workspace/cortex-mf/Cargo.lock file and found 20 packages
Scanned test/rust/workspace/cargo/Cargo.lock file and found 1 package
Scanned test/rust/workspace/clippy/Cargo.lock file and found 1 package
Scanned test/rust/workspace/test/Cargo.lock file and found 1 package
Scanned package-lock.json file and found 73 packages
End status: 103 dirs visited, 339 inodes visited, 8 Extract calls, 33.531896ms elapsed, 33.532116ms wall time

Total 3 packages affected by 3 known vulnerabilities (0 Critical, 1 High, 0 Medium, 0 Low, 2 Unknown) from 2 ecosystems.
1 vulnerability can be fixed.

+-------------------------------------+------+-----------+-----------------------+---------+---------------+---------------------------------------------------+
| OSV URL                             | CVSS | ECOSYSTEM | PACKAGE               | VERSION | FIXED VERSION | SOURCE                                            |
+-------------------------------------+------+-----------+-----------------------+---------+---------------+---------------------------------------------------+
| https://osv.dev/RUSTSEC-2026-0110   |      | crates.io | bare-metal            | 0.2.5   | --            | test/embedded-rust/workspace/cortex-m/Cargo.lock  |
| https://osv.dev/RUSTSEC-2026-0110   |      | crates.io | bare-metal            | 0.2.5   | --            | test/embedded-rust/workspace/cortex-mf/Cargo.lock |
| https://osv.dev/GHSA-3jxr-9vmj-r5cp | 7.7  | npm       | brace-expansion (dev) | 5.0.6   | 5.0.7         | package-lock.json                                 |
+-------------------------------------+------+-----------+-----------------------+---------+---------------+---------------------------------------------------+

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new docs devcontainer flavor aimed at documentation generation, and wires it into CI/release automation so it is built, scanned, and maintained like the existing flavors.

Changes:

  • Introduces the new .devcontainer/docs flavor (Dockerfile + pinned apt/pip dependencies + VS Code metadata).
  • Adds integration tests and sample workspace files to validate PlantUML, Graphviz, and SBDL in the docs image.
  • Updates GitHub workflows and release/dependency automation to include the new docs image.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/docs/workspace/sample.sbdl Adds a minimal SBDL model used by docs integration tests.
test/docs/workspace/graph.dot Adds a simple Graphviz graph used by docs integration tests.
test/docs/workspace/diagram.puml Adds a simple PlantUML diagram used by docs integration tests.
test/docs/integration-tests.bats Adds version + functional verification tests for docs tooling.
README.md Documents the new docs flavor and adds it to the published image list.
.github/workflows/wc-document-generation.yml Switches document generation to run inside the docs container.
.github/workflows/vulnerability-scan.yml Includes the docs image in scheduled vulnerability scanning.
.github/workflows/update-dependencies.yml Includes docs in dependency and VS Code extension update automation.
.github/workflows/release-build.yml Includes docs in release build/release-note generation matrix.
.github/workflows/pr-image-cleanup.yml Cleans up PR tags for the docs/base packages as well.
.github/workflows/image-cleanup.yml Cleans up untagged/orphaned docs/base images as well.
.github/workflows/build-push-test.yml Builds/tests the new docs flavor in the main build workflow matrix.
.github/RELEASE_TEMPLATE.md Adds release template placeholders for the docs image.
.github/dependabot.yml Adds .devcontainer/docs to Dependabot update scope.
.devcontainer/docs/requirements.txt Adds pinned, hashed Python dependencies for docs tooling.
.devcontainer/docs/requirements.in Adds the primary pinned Python dependency input (sbdl).
.devcontainer/docs/Dockerfile Defines the docs image build (apt + pip installs).
.devcontainer/docs/devcontainer.json Adds local development devcontainer definition for docs flavor.
.devcontainer/docs/devcontainer-metadata.json Adds VS Code extension metadata for docs flavor.
.devcontainer/docs/apt-requirements.json Adds pinned apt package versions for docs tooling.
.devcontainer/docs-test/devcontainer.json Adds test devcontainer config for validating built docs images.

Comment thread .github/workflows/wc-document-generation.yml Outdated
Comment thread .github/workflows/build-push-test.yml
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-docs:edgeghcr.io/philips-software/amp-devcontainer-docs:pr-1336

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 200.14 MB 200.14 MB +159 B (+0%) 🔼
linux/arm64 196.35 MB 196.35 MB +460 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1336

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 406.01 MB 406.02 MB +228 B (+0%) 🔼
linux/arm64 357.58 MB 357.58 MB +218 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1336

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 372.13 MB 372.13 MB +518 B (+0%) 🔼
linux/arm64 352.26 MB 352.26 MB +214 B (+0%) 🔼

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 4, 2026 15:28 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-cpp:edgeghcr.io/philips-software/amp-devcontainer-embedded-cpp:pr-1336

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 560.5 MB 560.5 MB 1.25 kB (0%) 🔽
linux/arm64 538.95 MB 538.95 MB +404 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Test Results

 25 files  ±0   25 suites  ±0   16m 22s ⏱️ - 3m 49s
 48 tests ±0   48 ✅ ±0  0 💤 ±0  0 ❌ ±0 
201 runs  ±0  201 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 834fbb5. ± Comparison against base commit 57ec6f1.

♻️ This comment has been updated with latest results.

Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 9, 2026 17:46
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/wc-document-generation.yml Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 17:47
Comment thread .github/workflows/wc-document-generation.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/wc-document-generation.yml Outdated
@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 9, 2026 17:57 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-rust:edgeghcr.io/philips-software/amp-devcontainer-embedded-rust:pr-1336

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 469.09 MB 469.09 MB +588 B (+0%) 🔼
linux/arm64 419.9 MB 419.91 MB +16.11 kB (+0%) 🔼

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 20, 2026 15:22 — with GitHub Actions Inactive
@sonarqubecloud

Copy link
Copy Markdown

@rjaegers
Ron (rjaegers) temporarily deployed to acceptance-testing July 21, 2026 07:21 — with GitHub Actions Inactive
@rjaegers
Ron (rjaegers) added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit b89caae Jul 21, 2026
91 checks passed
@rjaegers
Ron (rjaegers) deleted the feature/use-docs-flavor branch July 21, 2026 07:55
@github-actions

Copy link
Copy Markdown
Contributor

Pull Request Report (#1336)

Static measures

Description Value
Number of added lines 6
Number of deleted lines 18
Number of changed files 3
Number of commits 10
Number of reviews 7
Number of comments (w/o review comments) 9
Number of reviews that contains a comment to resolve 6
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 7

Time related measures

Description Value
PR lead time (from creation to close of PR) 16.7 Days
Time that was spend on the branch before the PR was created 3.6 Hours
Time that was spend on the branch before the PR was merged 16.8 Days
Time to merge after last review 22.4 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 1.6 Hours
Total time spend in last status check run on PR 43.6 Min

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v8.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants